Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @pinkisemils)

ios/MullvadVPN/View controllers/Account/AccountViewController.swift line 305 at r1 (raw file):

        }
        guard case let .received(oldProduct) = productState,
              let accountData = interactor.deviceState.accountData

is the let accountData meant to be duplicated?

ios/MullvadVPN/Classes/AccessbilityIdentifier.swift line 41 at r1 (raw file):

    case logoutButton
    case purchaseButton
    case storekit2Button

nit: capitalisation; i.e., perhaps this should be storeKit2Button?

Reviewable status: 4 of 7 files reviewed, 2 unresolved discussions (waiting on @acb-mv)

ios/MullvadVPN/Classes/AccessbilityIdentifier.swift line 41 at r1 (raw file):

You're correct!

ios/MullvadVPN/View controllers/Account/AccountViewController.swift line 305 at r1 (raw file):

Done.

Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved

I get a 400 from the API, "INVALID_INPUT". Is that expected before server side is done?

Reviewed 4 of 7 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @pinkisemils)

ios/MullvadVPN/Classes/AccessbilityIdentifier.swift line 41 at r3 (raw file):

    case logoutButton
    case purchaseButton
    case storeKit2Button

Nit: Unless we add E2E tests we don't need this. It doesn't hurt, but if this feature is being removed/renamed/other it seems likely we might forget to clean up this a11y id as well.

ios/MullvadVPN/View controllers/Account/AccountViewController.swift line 347 at r3 (raw file):

    private func sendReceiptToAPI(accountNumber: String, receipt: VerificationResult<Transaction>) async {
        do {
            // Accessing unsafe payload data because n

because "n"?

ios/MullvadVPN/View controllers/Account/PaymentAlertPresenter.swift line 39 at r3 (raw file):

    }

    func showAlertForStoreKitError(

We can use showAlertForError() above instead.

Reviewed 2 of 2 files at r4, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @pinkisemils)

That is to be expected. We might even change the button to use a different API call.

Reviewable status: 6 of 7 files reviewed, 2 unresolved discussions (waiting on @acb-mv and @rablador)

ios/MullvadVPN/View controllers/Account/AccountViewController.swift line 347 at r3 (raw file):

We actually don't we even need it. It's a leftover from when I was dumping the payload for inspecting it in the debugger.

ios/MullvadVPN/View controllers/Account/PaymentAlertPresenter.swift line 39 at r3 (raw file):

I don't think so, because it takes StorePaymentManagerError as an argument, which is an error that is only constructed by storekit1, I believe. But commits proving me wrong are welcome.

Reviewed 1 of 1 files at r5, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved

Reviewed all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved